KEMBAR78
build: include arrow dependency suggested compiler flags by diegomarquezp · Pull Request #3844 · googleapis/java-bigquery · GitHub
Skip to content

build: include arrow dependency suggested compiler flags #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

build: include arrow dependency suggested compiler flags #3844

merged 2 commits into from
Jun 12, 2025

Conversation

@diegomarquezp
Copy link
Contributor

This follows https://arrow.apache.org/docs/java/install.html, where we add the indicated --add-opens flag.

This is meant to follow from #3811 (comment)

@diegomarquezp
build: include arrow dependency suggested compiler flags
e27d5d0 
This follows https://arrow.apache.org/docs/java/install.html,
where we add the indicated `--add-opens` flag.

This is meant to follow from #3811 (comment)
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jun 11, 2025
@diegomarquezp diegomarquezp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2025
@diegomarquezp diegomarquezp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2025
@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Jun 12, 2025 •
edited
Loading

GraalVM C job failed with transient issue (log):

[ERROR] com.google.cloud.bigquery.it.ITRemoteUDFTest.testRoutineRemoteUDF -- Time elapsed: 5.955 s <<< ERROR!
com.google.cloud.bigquery.BigQueryException: An internal error occurred and the request could not be completed. This is usually caused by a transient issue. Retrying the job with back-off as described in the BigQuery SLA should solve the problem: https://cloud.google.com/bigquery/sla. If the error continues to occur please contact support at https://cloud.google.com/support. Error: 4316996

GraalVM B failed with (log):

JUnit Vintage:ITBigQueryTest:testExecuteSelectSinglePageTableRowColInd
    MethodSource [className = 'com.google.cloud.bigquery.it.ITBigQueryTest', methodName = 'testExecuteSelectSinglePageTableRowColInd', methodParameterTypes = '']
    => java.lang.IllegalArgumentException: Unexpected table cell format
       com.google.cloud.bigquery.FieldValue.fromPb(FieldValue.java:421)
       com.google.cloud.bigquery.FieldValue.fromPb(FieldValue.java:418)
       com.google.cloud.bigquery.FieldValueList.fromPb(FieldValueList.java:127)
       com.google.cloud.bigquery.FieldValueList.fromPb(FieldValueList.java:115)
       com.google.cloud.bigquery.ConnectionImpl$2.apply(ConnectionImpl.java:832)
       com.google.cloud.bigquery.ConnectionImpl$2.apply(ConnectionImpl.java:827)

This got past the arrow problem.
@jinseopkim0 what if we follow up in a separate PR to see the GraalVM B failures?

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2025
@jinseopkim0
Copy link
Contributor

Is the error irrelevant to the arrow related changes?

@diegomarquezp
Copy link
Contributor Author

Is the error irrelevant to the arrow related changes?

@jinseopkim0 yes, the new error occurs with the image itself. The arrow error happened at the JDK level.

@diegomarquezp diegomarquezp marked this pull request as ready for review June 12, 2025 15:14
@diegomarquezp diegomarquezp requested review from a team as code owners June 12, 2025 15:14
@jinseopkim0
Copy link
Contributor

Thanks for the reply. Do we have an issue open to track the error?

@diegomarquezp
Copy link
Contributor Author

The failures are of the form:

Failures (9):
  JUnit Vintage:ITBigQueryTest:testExecuteSelectSinglePageTableRowColInd
    MethodSource [className = 'com.google.cloud.bigquery.it.ITBigQueryTest', methodName = 'testExecuteSelectSinglePageTableRowColInd', methodParameterTypes = '']
    => java.lang.IllegalArgumentException: Unexpected table cell format
       com.google.cloud.bigquery.FieldValue.fromPb(FieldValue.java:421)
       com.google.cloud.bigquery.FieldValue.fromPb(FieldValue.java:418)
       com.google.cloud.bigquery.FieldValueList.fromPb(FieldValueList.java:127)
       com.google.cloud.bigquery.FieldValueList.fromPb(FieldValueList.java:115)
       com.google.cloud.bigquery.ConnectionImpl$2.apply(ConnectionImpl.java:832)
       com.google.cloud.bigquery.ConnectionImpl$2.apply(ConnectionImpl.java:827)
       com.google.common.collect.Iterators$6.transform(Iterators.java:830)
       com.google.common.collect.TransformedIterator.next(TransformedIterator.java:52)
       com.google.common.collect.ImmutableList.copyOf(ImmutableList.java:279)
       com.google.common.collect.ImmutableList.copyOf(ImmutableList.java:240)
       [...]

This happens in several tests (9 tests) with the same error.

We need to investigate whether this is specific to JDK 24 or if it was introduced with JDK 23.

@diegomarquezp diegomarquezp mentioned this pull request Jun 12, 2025
Open
@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Jun 12, 2025 •
edited
Loading

Thanks for the reply. Do we have an issue open to track the error?

@jinseopkim0, I created #3846

@diegomarquezp diegomarquezp merged commit 08772af into main Jun 12, 2025
20 of 22 checks passed
@diegomarquezp diegomarquezp deleted the arrow-add-opens-fix branch June 12, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpeddada1 mpeddada1 mpeddada1 approved these changes

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx alvarowolfx is a code owner automatically assigned from googleapis/api-bigquery

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@diegomarquezp @jinseopkim0 @mpeddada1 @yoshi-kokoro