KEMBAR78
fix: JsonWriter accepts string input for DATETIME, TIME, NUMERIC, BIGNUMERIC field by yirutang · Pull Request #1339 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix: JsonWriter accepts string input for DATETIME, TIME, NUMERIC, BIGNUMERIC field #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 1, 2021
Merged

fix: JsonWriter accepts string input for DATETIME, TIME, NUMERIC, BIGNUMERIC field #1339

merged 18 commits into from
Oct 1, 2021

Conversation

@yirutang
Copy link
Contributor

@yirutang yirutang commented Oct 1, 2021 •
edited
Loading

Fixes #1330

v1beta2 first and will port over the change to v1 later.

@yirutang yirutang requested a review from a team October 1, 2021 08:19
@yirutang yirutang requested a review from a team as a code owner October 1, 2021 08:19
@yirutang yirutang requested a review from loferris October 1, 2021 08:19
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Oct 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2021
@stephaniewang526
Copy link
Contributor

The change looks fine but looks like below test case needs to be updated:

Error:  Failures: 
Error:    BQTableSchemaToProtoDescriptorTest.testStructComplex:230->isDescriptorEqual:69 expected:<13> but was:<19>
Error:    JsonStreamWriterTest.testSingleAppendComplexJson:493 expected:<<ByteString@1e7e67d3 size=138 contents="\b\001\022\001a\022\001b\022\001c\032\005hello \001)\232\231\231\231\231\231\361?)\232\231\231\231\231\231\001@)ffffff\n@...">> but was:<<ByteString@12e56e82 size=141 contents="\b\001\022\001a\022\001b\022\001c\032\005hello \001)\232\231\231\231\231\231\361?)\232\231\231\231\231\231\001@)ffffff\n@...">>

@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2021
@yirutang yirutang merged commit 691f078 into googleapis:main Oct 1, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 6, 2021
@release-please
chore: release 2.3.3 (#1344)
2c51acb 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.3](https://www.github.com/googleapis/java-bigquerystorage/compare/v2.3.2...v2.3.3) (2021-10-05)


### Bug Fixes

* add string to DATETIME, TIME, NUMERIC, BIGNUMERIC support in JsonStreamWriter v1 ([#1345](https://www.github.com/googleapis/java-bigquerystorage/issues/1345)) ([9d272dd](https://www.github.com/googleapis/java-bigquerystorage/commit/9d272dd711dfe8909a7b421dabdcdef30f1dc689))
* JsonWriter accepts string input for DATETIME, TIME, NUMERIC, BIGNUMERIC field ([#1339](https://www.github.com/googleapis/java-bigquerystorage/issues/1339)) ([691f078](https://www.github.com/googleapis/java-bigquerystorage/commit/691f078f09e32fa7784d4afeeee0e8071f78d6fd))
* Sample should show sending multiple rows in one request ([#1335](https://www.github.com/googleapis/java-bigquerystorage/issues/1335)) ([3f85a68](https://www.github.com/googleapis/java-bigquerystorage/commit/3f85a68d6812aac94ca8a266d76be2aa94cd0b32))


### Documentation

* **samples:** Add WriteAPI BUFFERED mode sample ([#1338](https://www.github.com/googleapis/java-bigquerystorage/issues/1338)) ([5dfd523](https://www.github.com/googleapis/java-bigquerystorage/commit/5dfd5231c1ffa68a1b92ba01a9608d8cee2c0596))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v2.2.0 ([#1346](https://www.github.com/googleapis/java-bigquerystorage/issues/1346)) ([9370eb8](https://www.github.com/googleapis/java-bigquerystorage/commit/9370eb8ea74547792f9597d20707546836c417b6))
* update dependency com.google.cloud:google-cloud-bigquery to v2.2.1 ([#1347](https://www.github.com/googleapis/java-bigquerystorage/issues/1347)) ([406f5d3](https://www.github.com/googleapis/java-bigquerystorage/commit/406f5d3d446d3a9639b2c95590b3c6c38118d741))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
gcf-owl-bot bot added a commit that referenced this pull request Jan 25, 2022
@gcf-owl-bot
deps(java): update actions/github-script action to v5 (#1339)
b3cd02f 
Source-Link: googleapis/synthtool@466412a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:7062473f423f339256346ddbee3d81fb1de6b784fabc2a4d959d7df2c720e375
stephaniewang526 pushed a commit that referenced this pull request Jan 26, 2022
@gcf-owl-bot
deps(java): update actions/github-script action to v5 (#1339) (#1491)
7eea012 
Source-Link: googleapis/synthtool@466412a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:7062473f423f339256346ddbee3d81fb1de6b784fabc2a4d959d7df2c720e375

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please release-please bot mentioned this pull request Jan 26, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 28, 2022
@release-please
chore(main): release 2.8.3 (#1496)
fb545a9 
🤖 I have created a release *beep* *boop*
---


### [2.8.3](v2.8.2...v2.8.3) (2022-01-28)


### Dependencies

* **java:** update actions/github-script action to v5 ([#1339](#1339)) ([#1491](#1491)) ([7eea012](7eea012))
* update actions/github-script action to v5 ([#1492](#1492)) ([580c033](580c033))
* update dependency com.google.cloud:google-cloud-bigquery to v2.7.0 ([#1499](#1499)) ([0d414f8](0d414f8))
* upgrade google-cloud-shared-dependencies to v2.7.0 ([#1501](#1501)) ([3f75e83](3f75e83))


### Documentation

* **tutorials:** add a README.md ([#1500](#1500)) ([c50c6a0](c50c6a0))
* **tutorials:** add new tutorials directory and JsonWriterDefaultStream tutorial ([#1498](#1498)) ([fd1ecf2](fd1ecf2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@gcf-owl-bot
deps(java): update actions/github-script action to v5 (googleapis#1339)…
4c82c37 
… (googleapis#800)

Source-Link: googleapis/synthtool@466412a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:7062473f423f339256346ddbee3d81fb1de6b784fabc2a4d959d7df2c720e375

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@release-please
chore(main): release 0.123.19 (googleapis#793)
dbfb565 
🤖 I have created a release *beep* *boop*
---


### [0.123.19](googleapis/java-storage-nio@v0.123.18...v0.123.19) (2022-02-03)


### Dependencies

* **java:** update actions/github-script action to v5 ([googleapis#1339](googleapis/java-storage-nio#1339)) ([googleapis#800](googleapis/java-storage-nio#800)) ([4c82c37](googleapis/java-storage-nio@4c82c37))
* update actions/github-script action to v5 ([googleapis#799](googleapis/java-storage-nio#799)) ([40febb2](googleapis/java-storage-nio@40febb2))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([googleapis#802](googleapis/java-storage-nio#802)) ([2beefb6](googleapis/java-storage-nio@2beefb6))
* update dependency com.google.cloud:google-cloud-storage to v2.2.3 ([googleapis#786](googleapis/java-storage-nio#786)) ([b82657c](googleapis/java-storage-nio@b82657c))
* update dependency com.google.cloud:google-cloud-storage to v2.3.0 ([googleapis#796](googleapis/java-storage-nio#796)) ([e822be5](googleapis/java-storage-nio@e822be5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loferris loferris Awaiting requested review from loferris

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JsonToProtoMessage java.time.LocalDateTime error

2 participants

@yirutang @stephaniewang526