KEMBAR78
fix: Add unit test for closing disconnected streamwriter. by gnanda · Pull Request #1751 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix: Add unit test for closing disconnected streamwriter. #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix: Add unit test for closing disconnected streamwriter. #1751

merged 1 commit into from
Aug 18, 2022

Conversation

@gnanda
Copy link
Contributor

@gnanda gnanda commented Aug 16, 2022

Also reduce wait from 5->3 minutes

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@gnanda gnanda requested review from a team, Neenu1995 and yirutang August 16, 2022 18:48
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Aug 16, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2022
@gnanda gnanda added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2022
@gnanda gnanda merged commit 095d7d5 into googleapis:main Aug 18, 2022
@gnanda gnanda deleted the add_unit_test branch August 18, 2022 00:46
@release-please release-please bot mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yirutang yirutang yirutang approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gnanda @yirutang @Neenu1995 @yoshi-kokoro