fix: Fix window build bug caused by Instant resolution. #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prerequisite for multiplexing client
new stream name as a switch of destinationt
also fixed a tiny bug inside fake bigquery write impl for getting thre response from offset
possible the proto schema does not contain this field
product-auto-label
bot
added
size: xs
GaoleMeng
changed the title
GaoleMeng
changed the title
yirutang
previously approved these changes
Nov 15, 2022
Neenu1995
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Neenu1995
approved these changes
Nov 15, 2022
yirutang
reviewed
Nov 15, 2022
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
product-auto-label
bot
added
size: s
yirutang
reviewed
Nov 15, 2022
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
yirutang
approved these changes
Nov 15, 2022
GaoleMeng
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug happened because Windows Instant resolution is about 10ms level:
https://stackoverflow.com/a/20689231
We decided to change test directly, as in reality this bug can seldom happened due to the updated schema is required to happen after a server/client communication, which is at 100ms level
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.