KEMBAR78
feat: add routing header for multiplexed connection by yirutang · Pull Request #2035 · googleapis/java-bigquerystorage · GitHub
Skip to content

Conversation

@yirutang
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@yirutang yirutang requested review from a team and shollyman March 10, 2023 00:48
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Mar 10, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2023
@yirutang yirutang requested a review from GaoleMeng March 10, 2023 01:04
newHeaders.put(
"x-goog-request-params",
"write_location=" + getRoutingHeader(this.streamName, this.location));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we check on whether it's empty

@yirutang yirutang merged commit 1f2752f into googleapis:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants