KEMBAR78
fix: remove teh 30 minutes wait trying to refresh schema. Customers s… by yirutang · Pull Request #2088 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix: remove teh 30 minutes wait trying to refresh schema. Customers s… #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 26, 2023
Merged

fix: remove teh 30 minutes wait trying to refresh schema. Customers s… #2088

merged 5 commits into from
Apr 26, 2023

Conversation

@yirutang
Copy link
Contributor

…hould be ready to handle InvalidArgumentErrors, and removing the wait and retry can reduce their chance to get stuck

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@yirutang
fix: remove teh 30 minutes wait trying to refresh schema. Customers s…
46bf66e 
…hould be ready to handle InvalidArgumentErrors, and removing the wait and retry can reduce their chance to get stuck
@yirutang yirutang requested a review from a team as a code owner April 26, 2023 17:52
@yirutang yirutang requested a review from GaoleMeng April 26, 2023 17:52
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Apr 26, 2023
yirutang
yirutang commented Apr 26, 2023
View reviewed changes
Copy link
Contributor Author

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, PTAL.

@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner April 26, 2023 20:50
@yirutang yirutang merged commit 3ec294f into googleapis:main Apr 26, 2023
@release-please release-please bot mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaoleMeng GaoleMeng GaoleMeng approved these changes

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yirutang @GaoleMeng