KEMBAR78
feat!: use table name create default write stream issue fix by Le-Dai · Pull Request #2119 · googleapis/java-bigquerystorage · GitHub
Skip to content

feat!: use table name create default write stream issue fix #2119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 2, 2024
Merged

feat!: use table name create default write stream issue fix #2119

merged 5 commits into from
Jan 2, 2024

Conversation

@Le-Dai
Copy link
Contributor

@Le-Dai Le-Dai commented May 20, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@Le-Dai Le-Dai requested a review from a team as a code owner May 20, 2023 12:19
@Le-Dai Le-Dai requested a review from farhan0102 May 20, 2023 12:19
@google-cla
Copy link

google-cla bot commented May 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented May 20, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label May 21, 2023
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 30, 2023
@Neenu1995
Copy link
Contributor

@MrDLontheway Please sign the CLA

@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 30, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner May 30, 2023 18:37
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 30, 2023
@Le-Dai Le-Dai changed the title use table name create default write stream issue fix feat!: use table name create default write stream issue fix Jul 18, 2023
@Le-Dai
Copy link
Contributor Author

Le-Dai commented Jul 18, 2023

@MrDLontheway Please sign the CLA

done

@Le-Dai Le-Dai requested a review from yirutang July 18, 2023 03:46
yirutang
yirutang reviewed Jul 21, 2023
View reviewed changes
...querystorage/src/main/java/com/google/cloud/bigquery/storage/v1/SchemaAwareStreamWriter.java Outdated
private static final String streamPatternString =
"(projects/[^/]+/datasets/[^/]+/tables/[^/]+)/streams/[^/]+";
private static final String tablePatternString = "(projects/[^/]+/datasets/[^/]+/tables/[^/]+)";
private static final String defaultTablePatternString = tablePatternString + "/_default";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be defaultStream instead of defaultTable?

@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 15, 2023
@yirutang yirutang added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 15, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 15, 2023
@yirutang yirutang added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 2, 2024
@yirutang yirutang added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 2, 2024
@yirutang yirutang merged commit 91a2bec into googleapis:main Jan 2, 2024
@release-please release-please bot mentioned this pull request Jan 2, 2024
Merged
@yirutang
Copy link
Contributor

I don't know why this is marked as breaking change...

@suztomo
Copy link
Member

suztomo commented Jan 22, 2024

The "!" in the "feat!" conventional commit title.

@yirutang
Copy link
Contributor

The "!" in the "feat!" conventional commit title.

Hoops, will pay attention to this in code review later. Thanks for the reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yirutang yirutang yirutang approved these changes

@farhan0102 farhan0102 Awaiting requested review from farhan0102 farhan0102 is a code owner automatically assigned from googleapis/api-bigquery

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Le-Dai @Neenu1995 @yirutang @suztomo @yoshi-kokoro