feat: improve json to proto conversion by caching schema #2179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eue. Since in write api server side we have total timeout of 2 minutes, it does not make sense to wait 15 minutes to determine whether we have met dead connection, let's reduce the timeout here
explicitly provided 2. fix location string matching for multiplexing
product-auto-label
bot
added
size: l
yirutang
reviewed
Jul 10, 2023
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessage.java
Show resolved
Hide resolved
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessage.java
Outdated
Show resolved
Hide resolved
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ToProtoConverter.java
Show resolved
Hide resolved
...gquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessageTest.java
Show resolved
Hide resolved
...gquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessageTest.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java
Show resolved
Hide resolved
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessage.java
Outdated
Show resolved
Hide resolved
GaoleMeng
force-pushed
the
main
branch
5 times, most recently
from
fb52950 to
403c6b3
Compare
yirutang
reviewed
Jul 11, 2023
...querystorage/src/main/java/com/google/cloud/bigquery/storage/v1/SchemaAwareStreamWriter.java
Show resolved
Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java
Show resolved
Hide resolved
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessage.java
Show resolved
Hide resolved
GaoleMeng
force-pushed
the
main
branch
11 times, most recently
from
a6f49fa to
561cdf1
Compare
yirutang
reviewed
Jul 12, 2023
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ToProtoConverter.java
Show resolved
Hide resolved
GaoleMeng
force-pushed
the
main
branch
3 times, most recently
from
ec44394 to
a856a68
Compare
yirutang
approved these changes
Jul 12, 2023
caching the schema. This will introduce approximately 2x improvement to append speed
GaoleMeng
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
GaoleMeng
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
GaoleMeng
added
external
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By caching schema across rows during conversion, we could save ~2x conversion speed for wide schema and when the row count is large
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.