KEMBAR78
fix : using context from call in ReadRowsRetryingCallable by isha97 · Pull Request #2560 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix : using context from call in ReadRowsRetryingCallable #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix : using context from call in ReadRowsRetryingCallable #2560

merged 1 commit into from
Jul 19, 2024

Conversation

isha97
Copy link
Contributor

@isha97 isha97 commented Jul 16, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@isha97 isha97 requested a review from a team as a code owner July 16, 2024 21:37
@isha97 isha97 requested a review from farhan0102 July 16, 2024 21:37
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Jul 16, 2024
@isha97 isha97 force-pushed the fix-call-context branch from 810d707 to 1887ed9 Compare July 16, 2024 21:40
@isha97
Copy link
Contributor Author

isha97 commented Jul 16, 2024

/gcbrun

@isha97 isha97 changed the title Using context from call in ReadRowsRetryingCallable fix : using context from call in ReadRowsRetryingCallable Jul 16, 2024
@isha97 isha97 force-pushed the fix-call-context branch from 1887ed9 to 63f5ca9 Compare July 17, 2024 17:18
@agrawal-siddharth
Copy link
Contributor

Could you elaborate on what case this change fixes?

@isha97 isha97 force-pushed the fix-call-context branch from 63f5ca9 to cdbf42c Compare July 18, 2024 18:23
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 18, 2024
@agrawal-siddharth
Copy link
Contributor

/gcbrun

@agrawal-siddharth agrawal-siddharth added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 19, 2024
@farhan0102 farhan0102 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2024
@agrawal-siddharth agrawal-siddharth merged commit eeb19b7 into googleapis:main Jul 19, 2024
@release-please release-please bot mentioned this pull request Jul 19, 2024
Merged
yifatgortler pushed a commit to yifatgortler/java-bigquerystorage that referenced this pull request Jul 25, 2024
@isha97 @yifatgortler
fix: using context from call in ReadRowsRetryingCallable (googleapis#…
4dd8100 
…2560)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agrawal-siddharth agrawal-siddharth agrawal-siddharth approved these changes

@farhan0102 farhan0102 Awaiting requested review from farhan0102 farhan0102 is a code owner automatically assigned from googleapis/api-bigquery

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isha97 @agrawal-siddharth @farhan0102 @yoshi-kokoro