KEMBAR78
fix: RequestProfilerTest.java regex in deep-preserve list by PhongChuong · Pull Request #2589 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix: RequestProfilerTest.java regex in deep-preserve list #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix: RequestProfilerTest.java regex in deep-preserve list #2589

merged 1 commit into from
Jul 31, 2024

Conversation

@PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Jul 31, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2588

@PhongChuong PhongChuong requested review from a team as code owners July 31, 2024 14:27
@PhongChuong PhongChuong merged commit e62ac66 into main Jul 31, 2024
@PhongChuong PhongChuong deleted the i2588 branch July 31, 2024 18:11
@PhongChuong PhongChuong mentioned this pull request Aug 2, 2024
Merged
@release-please release-please bot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp

@GaoleMeng GaoleMeng Awaiting requested review from GaoleMeng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RequestProfilerTest.java is incorrectly being removed autogenerated code PR

2 participants

@PhongChuong @shollyman