KEMBAR78
Make client robust to Rst from OkHTTP by emkornfield · Pull Request #1358 · googleapis/java-bigquerystorage · GitHub
Skip to content

Make client robust to Rst from OkHTTP #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2021
Merged

Make client robust to Rst from OkHTTP #1358

merged 1 commit into from
Oct 18, 2021

Conversation

@emkornfield
Copy link
Contributor

The
OKHTTP
transport uses slightly different error messages for RST Stream that
aren't caught by current screen scraping. This adds a check for the
strict explicitly.

bug: Retry RST Stream on OKHTTP.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@emkornfield emkornfield requested review from a team and loferris October 13, 2021 19:38
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Oct 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2021
@emkornfield
Copy link
Contributor Author

CC @stephaniewang526

fix: Make client robust to Rst from OkHTTP
0c6d339 
The
[OKHTTP](https://github.com/grpc/grpc-java/blob/d4fa0ecc07495097453b0a2848765f076b9e714c/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java#L1241)
transport uses slightly different error messages for RST Stream that
aren't caught by current screen scraping.  This adds a check for the
strict explicitly.
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2021
@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 03f9d75 into googleapis:main Oct 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loferris loferris Awaiting requested review from loferris

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emkornfield @stephaniewang526