KEMBAR78
chore: update method doc for v1 ReadRowsRequest methods by jhambleton · Pull Request #1389 · googleapis/java-bigquerystorage · GitHub
Skip to content

chore: update method doc for v1 ReadRowsRequest methods #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

chore: update method doc for v1 ReadRowsRequest methods #1389

merged 1 commit into from
Oct 28, 2021

Conversation

@jhambleton
Copy link
Contributor

update for ReadRowsRequest docs, including java doc, for methods which are inaccurate.

fix will help clarify usage for end users of the sdk

@jhambleton jhambleton requested review from a team and shollyman October 27, 2021 18:25
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Oct 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2021
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-bigquerystorage-v1/src/main/java/com/google/cloud/bigquery/storage/v1/ReadRowsRequest.java

stephaniewang526
stephaniewang526 suggested changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@stephaniewang526 stephaniewang526 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jhambleton , thank you for your contribution!

Please amend your initial commit message to "chore: update method doc for v1 ReadRowsRequest methods" since fix will trigger a client lib minor version bump and this is not it. It would also clear the conventionalcommit failure you're seeing here.

@jhambleton jhambleton changed the title fix: update method doc for v1 ReadRowsRequest methods chore: update method doc for v1 ReadRowsRequest methods Oct 27, 2021
@jhambleton
Copy link
Contributor Author

thanks @stephaniewang526 for the quick feedback! Updated PR title & initial commit. Keep me posted if you spot anything else. appreciate it.

@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2021
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 27, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 28, 2021
@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 28, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit cbdbaab into googleapis:main Oct 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman Awaiting requested review from shollyman

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhambleton @stephaniewang526 @yoshi-kokoro