KEMBAR78
fix: timestamp as microseconds by dark0dave · Pull Request #1582 · googleapis/java-bigquerystorage · GitHub
Skip to content

Conversation

@dark0dave
Copy link
Contributor

@dark0dave dark0dave commented Mar 21, 2022

Fixes #1579
Timestamps are now parsed by Big Query, rather than treating them as milliseconds they are now correctly treated as microseconds

@dark0dave dark0dave requested review from a team and stephaniewang526 March 21, 2022 12:15
@google-cla
Copy link

google-cla bot commented Mar 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Mar 21, 2022
@dark0dave
Copy link
Contributor Author

dark0dave commented Mar 21, 2022

I can confirm this is fixed by this pr:
image
Lines 1->14 use the old release. And line 15 I am using a local snapshot from my pr.

@dark0dave
Copy link
Contributor Author

CLA signed can we get this merged?

@dark0dave
Copy link
Contributor Author

@blakeli0 could you review?

@geirsagberg
Copy link

@dark0dave I don't think this fixes #1580 ; Timestamp.valueOf("2022-01-01T12:00:00Z") will still fail :(

@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 23, 2022
@dark0dave
Copy link
Contributor Author

@geirsagberg will fix in another pr. Lets get this fix in first.

@dark0dave
Copy link
Contributor Author

@stephaniewang526 updated for lint to pass.

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 23, 2022
Signed-off-by: dark0dave <dark0dave@mykolab.com>
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@stephaniewang526 stephaniewang526 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@stephaniewang526 stephaniewang526 removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 28, 2022
@stephaniewang526
Copy link
Contributor

This is resolved as part of #1589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timestamp still not parsed correctly

3 participants