KEMBAR78
fix: more writeapi manual client test issues by yirutang · Pull Request #241 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix: more writeapi manual client test issues #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2020
Merged

fix: more writeapi manual client test issues #241

merged 2 commits into from
May 4, 2020

Conversation

@yirutang
Copy link
Contributor

@yirutang yirutang commented May 1, 2020 •
edited
Loading

  • Fix some unwanted exceptions in the test run by make sure writers are cleaned up.
  • Fix another executor race issue.
  • The reconnection test failure is wired, it seems the test was shut down while running. I split the tests into 3 and reduce its run length. It could be due to testing taking too long to run (each wait is 7 seconds and there were 4 waits).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2020
@yirutang yirutang changed the title fix: more test issues fix: more writeapi manual client test issues May 1, 2020
@yirutang
fix: more test issues
2c8da9d 
- Fix some unwanted exceptions in the test run by make sure writers are cleaned up.
- Fix another executor race issue.
- The reconnection test failure is wired, it seems the test was shut down while running. I split the tests into 3 and reduce its run length. It could be due to testing taking too long to run (each wait is 7 seconds and there were 4 waits).

	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriterCache.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/WriterCacheTest.java
@stephaniewang526 stephaniewang526 self-requested a review May 1, 2020 23:38
stephaniewang526
stephaniewang526 suggested changes May 1, 2020
View reviewed changes
Copy link
Contributor

@stephaniewang526 stephaniewang526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are still failing

@codecov
Copy link

codecov bot commented May 4, 2020 •
edited
Loading

Codecov Report

Merging #241 into master will increase coverage by 1.16%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
+ Coverage     74.02%   75.19%   +1.16%     
- Complexity      346      368      +22     
============================================
  Files            45       45              
  Lines          2387     2471      +84     
  Branches         89       93       +4     
============================================
+ Hits           1767     1858      +91     
+ Misses          575      569       -6     
+ Partials         45       44       -1
Impacted Files Coverage Δ Complexity Δ
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 83.53% <50.00%> (+1.87%) 34.00 <0.00> (ø)
...e/cloud/bigquery/storage/v1alpha2/WriterCache.java 91.76% <100.00%> (+3.05%) 14.00 <0.00> (+4.00)
...rage/v1beta1/stub/EnhancedBigQueryStorageStub.java 86.27% <0.00%> (+0.27%) 9.00% <0.00%> (+1.00%)
...orage/v1alpha2/stub/BigQueryWriteStubSettings.java 81.57% <0.00%> (+0.32%) 14.00% <0.00%> (ø%)
...y/storage/v1alpha2/stub/GrpcBigQueryWriteStub.java 95.00% <0.00%> (+0.40%) 14.00% <0.00%> (+1.00%)
...uery/storage/v1/stub/EnhancedBigQueryReadStub.java 82.92% <0.00%> (+0.42%) 7.00% <0.00%> (+1.00%)
...storage/v1beta2/stub/EnhancedBigQueryReadStub.java 82.92% <0.00%> (+0.42%) 7.00% <0.00%> (+1.00%)
...rage/v1beta1/stub/BigQueryStorageStubSettings.java 84.72% <0.00%> (+0.43%) 14.00% <0.00%> (ø%)
.../storage/v1beta1/stub/GrpcBigQueryStorageStub.java 93.12% <0.00%> (+0.50%) 12.00% <0.00%> (+1.00%)
...uery/storage/v1/stub/BigQueryReadStubSettings.java 84.67% <0.00%> (+0.51%) 12.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74c0ce...ad9d8c6. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 65c5ec9 into googleapis:master May 4, 2020
@yirutang yirutang deleted the fix-3 branch June 5, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yirutang @stephaniewang526 @googlebot