KEMBAR78
fix: github workflow vulnerable to script injection by diogoteles08 · Pull Request #2600 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix: github workflow vulnerable to script injection #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2024
Merged

fix: github workflow vulnerable to script injection #2600

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2bad5c2
fix: github workflow vulnerable to script injection
diogoteles08 Aug 8, 2024
baa7399
inline forked repo check
diegomarquezp Aug 19, 2024
3de621e
Update hermetic_library_generation.yaml
diegomarquezp Aug 19, 2024
7dfd3eb
remove unnecessary variable evaluation token
diegomarquezp Aug 19, 2024
ff3609a
fix wording
diegomarquezp Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/hermetic_library_generation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,14 @@ name: Hermetic library generation upon generation config change through pull req
on:
pull_request:

env:
HEAD_REF: ${{ github.head_ref }}
REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }}

jobs:
library_generation:
# skip pull requests come from a forked repository
if: github.event.pull_request.head.repo.full_name == github.repository
# skip pull requests coming from a forked repository
if: github.env.REPO_FULL_NAME == github.repository
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -35,6 +39,6 @@ jobs:
[ -z "$(git config user.name)" ] && git config --global user.name "cloud-java-bot"
bash .github/scripts/hermetic_library_generation.sh \
--target_branch ${{ github.base_ref }} \
--current_branch ${{ github.head_ref }}
--current_branch $HEAD_REF
env:
GH_TOKEN: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }}