KEMBAR78
fix: adding more logging to retry test by yirutang · Pull Request #342 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix: adding more logging to retry test #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

fix: adding more logging to retry test #342

merged 1 commit into from
Jun 11, 2020

Conversation

@yirutang
Copy link
Contributor

There is a test failure that we kept sending retry requests exceeding max attempt number.
Could be due to some race on currentRetries count? I couldn't repro it on my local machine.

Added some logging and moved currentRetries count after we set the exception.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 11, 2020
@stephaniewang526 stephaniewang526 self-requested a review June 11, 2020 21:32
stephaniewang526
stephaniewang526 suggested changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@stephaniewang526 stephaniewang526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this branch on master and only include the single new commit you want in the PR.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020 •
edited
Loading

Codecov Report

Merging #342 into master will decrease coverage by 0.25%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #342      +/-   ##
============================================
- Coverage     75.79%   75.53%   -0.26%     
  Complexity      466      466              
============================================
  Files            54       54              
  Lines          3119     3123       +4     
  Branches        175      166       -9     
============================================
- Hits           2364     2359       -5     
- Misses          650      653       +3     
- Partials        105      111       +6
Impacted Files Coverage Δ Complexity Δ
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 81.07% <50.00%> (-0.53%) 34.00 <0.00> (ø)
...bigquery/storage/v1alpha2/BigQueryWriteClient.java 52.85% <0.00%> (-5.72%) 28.00% <0.00%> (ø%)
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 41.46% <0.00%> (-2.44%) 10.00% <0.00%> (ø%)
...gquery/storage/v1beta2/BaseBigQueryReadClient.java 41.46% <0.00%> (-2.44%) 10.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7df51...921ef50. Read the comment docs.

@yirutang
Copy link
Contributor Author

Rebase worked, PTAL.

@stephaniewang526 stephaniewang526 merged commit af80eac into googleapis:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yirutang @googlebot @stephaniewang526