KEMBAR78
equals is broken for UpdateAppProfileRequest · Issue #1105 · googleapis/java-bigtable · GitHub
Skip to content

equals is broken for UpdateAppProfileRequest #1105

New issue
New issue
Closed
#1142
Closed
equals is broken for UpdateAppProfileRequest#1105
#1142
Labels
api: bigtableIssues related to the googleapis/java-bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
@igorbernstein2

Description

@igorbernstein2
igorbernstein2
opened on Dec 16, 2021

java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequest.java

Line 154 in 0d197a5

&& Objects.equal(proto, that.proto);

The proto comparison must build the proto before comparison. Also, comparing the proto is problematic here since the proto builder mutates when toProto((String projectId) is called

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: bigtableIssues related to the googleapis/java-bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions