KEMBAR78
fix: only record retry count when it's > 0 by mutianf · Pull Request #1488 · googleapis/java-bigtable · GitHub
Skip to content

fix: only record retry count when it's > 0 #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2022
Merged

fix: only record retry count when it's > 0 #1488

merged 2 commits into from
Nov 1, 2022

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Nov 1, 2022 •
edited
Loading

grpc is also publishing this metric as a sum aggregation: https://github.com/grpc/proposal/blob/master/A45-retry-stats.md

@mutianf mutianf requested a review from a team as a code owner November 1, 2022 14:28
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Nov 1, 2022
igorbernstein2
igorbernstein2 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 1, 2022
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner November 1, 2022 15:30
@mutianf mutianf merged commit 445a667 into googleapis:main Nov 1, 2022
@mutianf mutianf deleted the retry branch November 1, 2022 16:19
@release-please release-please bot mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mutianf @igorbernstein2