feat: add APIs to enable batch write flow control #1730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableBatchingCallSettings.java
Show resolved
Hide resolved
Comment on lines
739
to
740
| ServerStreamingCallable<MutateRowsRequest, MutateRowsResponse> rateLimitingStreamingCallable = | ||
| null; |
There was a problem hiding this comment.
this is a bit ugly. I think it might be easier to follow by having a local callable variable that just get reassigned in each step:
ServerStreamingCallable<MutateRowsRequest, MutateRowsResponse> callable = GrpcRawCallableFactory.createServerStreamingCallable(...);
callable = new StatsHeadersServerStreamingCallable<>(callable);
if (settings.bulkMutateRowsSettings().isServerInitiatedFlowControlEnabled()) {
callable = new RateLimitingServerStreamingCallable(callable);
}
callable = new ConvertExceptionCallable<>(callable...);
...
There was a problem hiding this comment.
Ok, I updated the withStatsHeader callable so I don't need to change too much original code :)
igorbernstein2
approved these changes
May 1, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.