fix: add RetryCallable to the callable chain #2348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
mutianf
changed the title
product-auto-label
bot
added
size: m
jackdingilian
approved these changes
Sep 20, 2024
| // TODO resumption strategy and retry settings | ||
| .build(); | ||
|
|
||
| ServerStreamingCallable<ExecuteQueryCallContext, SqlRow> retries = |
There was a problem hiding this comment.
Will you put a comment noting that this is just for client side metrics and we don't want any retries to happen right now?
mutianf
force-pushed
the
retry-callable
branch
from
452abc7 to
413c0e2
Compare
jackdingilian
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.