feat: add support for table deletion protection #2430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
size: m
…ection' into table_deletion_protection
adashyan
changed the title
yoshi-kokoro
removed
the
kokoro:run
mutianf
reviewed
Nov 22, 2024
| return changeStreamRetention; | ||
| } | ||
|
|
||
| public boolean isProtected() { |
There was a problem hiding this comment.
Add a comment: /** Returns whether this table is deletion protected. */
and rename it to isDeletionProtected to be consistent with authorized view
| if (!(o instanceof UpdateTableRequest)) return false; | ||
| UpdateTableRequest that = (UpdateTableRequest) o; | ||
| return Objects.equals(requestBuilder, that.requestBuilder); | ||
| return Objects.equals(requestBuilder.build(), that.requestBuilder.build()); |
There was a problem hiding this comment.
I can remove it but that's what we do in other like CreateTableRequest
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(requestBuilder); | ||
| return Objects.hash(requestBuilder.build()); |
There was a problem hiding this comment.
same here, why changing this?
mutianf
approved these changes
Nov 22, 2024
|
/gcbrun |
yoshi-kokoro
removed
the
kokoro:run
mutianf
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
🤖 I have created a release *beep* *boop* --- ## [2.49.0](https://togithub.com/googleapis/java-bigtable/compare/v2.48.0...v2.49.0) (2024-12-03) ### Features * Add support for table deletion protection ([#2430](https://togithub.com/googleapis/java-bigtable/issues/2430)) ([687b6df](https://togithub.com/googleapis/java-bigtable/commit/687b6df14b743358e8207cda26022dfc75338d55)) ### Bug Fixes * Allow factory to export to different projects ([#2374](https://togithub.com/googleapis/java-bigtable/issues/2374)) ([06b912c](https://togithub.com/googleapis/java-bigtable/commit/06b912cc5d63436757008e79edfa8286b2ccac18)) * Send priming requests on the channel directly ([#2435](https://togithub.com/googleapis/java-bigtable/issues/2435)) ([b76698d](https://togithub.com/googleapis/java-bigtable/commit/b76698dfb2c8552185f34e01e924ecc80798ba4f)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.