feat: add BigtableDataClientFactory to create lightweight data clients #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new factory allows users to construct a single heavy factory object that can create many lightweight clients. This is meant to be used in situations when a single application needs to access multiple instances or use different application profiles
googlebot
added
the
cla: yes
|
@tonytanger Can you take a look as well? I want to make sure this doesn't conflict with your channel refresh work |
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
============================================
+ Coverage 81.33% 81.74% +0.41%
- Complexity 937 952 +15
============================================
Files 95 97 +2
Lines 5850 5927 +77
Branches 325 327 +2
============================================
+ Hits 4758 4845 +87
+ Misses 916 904 -12
- Partials 176 178 +2
Continue to review full report at Codecov.
|
kolea2
reviewed
Dec 10, 2019
...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClientFactory.java
Show resolved
Hide resolved
igorbernstein2
added
the
do not merge
kolea2
approved these changes
Dec 11, 2019
rahulKQL
approved these changes
Dec 11, 2019
kolea2
added
the
kokoro:force-run
|
LGTM. Don't think primechannel and this will conflict. |
kolea2
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
igorbernstein2
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new factory allows users to construct a single heavy factory object that can create many lightweight clients.
This is meant to be used in situations when a single application needs to access multiple instances or use different application profiles