KEMBAR78
chore: move cloud monitoring bom to deps bom by kolea2 · Pull Request #1388 · googleapis/java-bigtable · GitHub
Skip to content

chore: move cloud monitoring bom to deps bom #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 15, 2022
Merged

chore: move cloud monitoring bom to deps bom #1388

merged 5 commits into from
Sep 15, 2022

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented Sep 9, 2022

No description provided.

@kolea2 kolea2 requested review from a team as code owners September 9, 2022 13:48
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 9, 2022
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
igorbernstein2
igorbernstein2 reviewed Sep 9, 2022
View reviewed changes
pom.xml Outdated
<github.global.server>github</github.global.server>
<site.installationModule>google-cloud-bigtable-parent</site.installationModule>
<project.javadoc.protobufBaseURL>https://googleapis.dev/java/google-api-grpc/latest</project.javadoc.protobufBaseURL>
<cloud.monitoring.version>3.4.2</cloud.monitoring.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in the deps-bom

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 9, 2022
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@kolea2 kolea2 changed the title chore: move cloud monitoring version property to parent pom chore: move cloud monitoring version property to deps bom Sep 9, 2022
@kolea2 kolea2 changed the title chore: move cloud monitoring version property to deps bom chore: move cloud monitoring bom to deps bom Sep 9, 2022
igorbernstein2
igorbernstein2 approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kolea2 kolea2 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 15, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 768fe52 into googleapis:main Sep 15, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kolea2 @igorbernstein2