chore: force compute engine creds for directpath test #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
=========================================
Coverage ? 81.92%
Complexity ? 971
=========================================
Files ? 99
Lines ? 6021
Branches ? 330
=========================================
Hits ? 4933
Misses ? 910
Partials ? 178Continue to review full report at Codecov.
|
igorbernstein2
force-pushed
the
fix-dp
branch
from
bcc3964 to
ae9135e
Compare
kolea2
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectPath requires compute channel credentials. If any other credentials are set, then it will silently fallback to cloud path. The DirectPathFallbackIT requires the connection to use DirectPath, however kokoro currently configures GOOGLE_APPLICATION_CREDENTIALS for all tests. So this PR forcefully sets the credentials provider to be ComputeEngineCredentials