KEMBAR78
fix: set wait timeout on watchdog by mutianf · Pull Request #1898 · googleapis/java-bigtable · GitHub
Skip to content

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Aug 31, 2023

And add wait timeout on CDC settings.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 31, 2023
@mutianf mutianf marked this pull request as ready for review August 31, 2023 15:17
@mutianf mutianf requested a review from a team as a code owner August 31, 2023 15:17
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Aug 31, 2023
Comment on lines +724 to +725
.setIdleTimeout(Duration.ofMinutes(5))
.setWaitTimeout(Duration.ofMinutes(5));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should lower the wait timeout to 1m

.setRetrySettings(GENERATE_INITIAL_CHANGE_STREAM_PARTITIONS_RETRY_SETTINGS)
.setIdleTimeout(Duration.ofMinutes(5));
.setIdleTimeout(Duration.ofMinutes(5))
.setWaitTimeout(Duration.ofMinutes(5));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should lower the waitTimeout to 1m

@igorbernstein2
Copy link
Contributor

closing in favor of #1913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants