KEMBAR78
test: add test to ensure that feature flags are sent during a ping and warm rpc by igorbernstein2 · Pull Request #2425 · googleapis/java-bigtable · GitHub
Skip to content

Conversation

@igorbernstein2
Copy link
Contributor

Change-Id: I7d8ac74eae66d34de453b0cd799f45474d6ff0f7

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@igorbernstein2 igorbernstein2 requested review from a team as code owners November 19, 2024 14:06
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Nov 19, 2024
@cloud-java-bot cloud-java-bot requested a review from a team as a code owner November 19, 2024 14:10
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Nov 20, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2024
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 26, 2024
…d warm rpc

Change-Id: I7d8ac74eae66d34de453b0cd799f45474d6ff0f7
Change-Id: Ib68d515513fcdfee1df1c2f3435a1e9c64e0c8fc
Change-Id: I2f215d40df99f6e0a834c3416ded35d4b2a44d97
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 3, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit e1c7804 into main Dec 3, 2024
23 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 3, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the ping-test branch December 3, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants