KEMBAR78
chore: Create CODEOWNERS by czahedi · Pull Request #284 · googleapis/java-bigtable · GitHub
Skip to content

chore: Create CODEOWNERS #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2020
Merged

chore: Create CODEOWNERS #284

merged 2 commits into from
May 12, 2020

Conversation

@czahedi
Copy link
Contributor

@czahedi czahedi commented May 6, 2020

Adding owner team

@czahedi
Create CODEOWNERS
4dbd5f5 
Adding owner team
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020 •
edited
Loading

Codecov Report

Merging #284 into master will decrease coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #284      +/-   ##
============================================
- Coverage     79.82%   79.52%   -0.31%     
- Complexity      991      992       +1     
============================================
  Files            99       99              
  Lines          6414     6447      +33     
  Branches        319      318       -1     
============================================
+ Hits           5120     5127       +7     
- Misses         1098     1119      +21     
- Partials        196      201       +5
Impacted Files Coverage Δ Complexity Δ
...d/bigtable/data/v2/stub/readrows/StateMachine.java 89.58% <100.00%> (ø) 15.00 <3.00> (ø)
...d/bigtable/data/v2/models/MutateRowsException.java 75.00% <0.00%> (-8.34%) 3.00% <0.00%> (ø%)
...ata/v2/stub/readrows/FilterMarkerRowsCallable.java 83.87% <0.00%> (-6.46%) 2.00% <0.00%> (ø%)
...able/admin/v2/BaseBigtableInstanceAdminClient.java 57.07% <0.00%> (-3.14%) 56.00% <0.00%> (ø%)
...igtable/admin/v2/BaseBigtableTableAdminClient.java 58.18% <0.00%> (-1.98%) 67.00% <0.00%> (ø%)
.../admin/v2/stub/BigtableTableAdminStubSettings.java 94.26% <0.00%> (ø) 36.00% <0.00%> (ø%)
...min/v2/stub/BigtableInstanceAdminStubSettings.java 96.05% <0.00%> (ø) 33.00% <0.00%> (ø%)
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 95.15% <0.00%> (+0.04%) 20.00% <0.00%> (ø%)
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java 95.26% <0.00%> (+0.08%) 21.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88547c...c2fdbd5. Read the comment docs.

igorbernstein2
igorbernstein2 reviewed May 7, 2020
View reviewed changes
chingor13
chingor13 reviewed May 7, 2020
View reviewed changes
@czahedi czahedi changed the title Create CODEOWNERS feat: Create CODEOWNERS May 11, 2020
@chingor13 chingor13 changed the title feat: Create CODEOWNERS chore: Create CODEOWNERS May 12, 2020
@czahedi czahedi requested a review from kolea2 May 12, 2020 15:12
@kolea2 kolea2 merged commit 0428d32 into master May 12, 2020
@kolea2 kolea2 deleted the czahedi-patch-1 branch May 12, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 left review comments

@igorbernstein2 igorbernstein2 igorbernstein2 left review comments

+1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@czahedi @chingor13 @igorbernstein2 @kolea2 @googlebot