KEMBAR78
[CHANGE ME] Re-generated to pick up changes in the API or client library generator. by yoshi-automation · Pull Request #289 · googleapis/java-bigtable · GitHub
Skip to content

Conversation

@yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/58859d5a-5b46-46ff-9dbb-f136a9f5d973/targets

PiperOrigin-RevId: 310426317
Source-Link: googleapis/googleapis@fb8f62b
PiperOrigin-RevId: 309824146
Source-Link: googleapis/googleapis@e0f9d9e

This PR uses using documentai as an example.
Depends on googleapis/gapic-generator-python#402

PiperOrigin-RevId: 309824146

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 4 15:06:44 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb
Source-Link: googleapis/googleapis@e0f9d9e
Committer: @miraleung
PiperOrigin-RevId: 310426317

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu May 7 13:31:13 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: fb8f62b6784f43faf4b64179c57ce4b4931b1a00
Source-Link: googleapis/googleapis@fb8f62b
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2020
@kolea2 kolea2 requested a review from igorbernstein2 May 8, 2020 14:15
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #289 into master will decrease coverage by 0.26%.
The diff coverage is 69.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
- Coverage     79.82%   79.55%   -0.27%     
  Complexity      991      991              
============================================
  Files            99       99              
  Lines          6414     6442      +28     
  Branches        319      318       -1     
============================================
+ Hits           5120     5125       +5     
- Misses         1098     1116      +18     
- Partials        196      201       +5     
Impacted Files Coverage Δ Complexity Δ
...min/v2/stub/BigtableInstanceAdminStubSettings.java 96.05% <0.00%> (ø) 33.00 <0.00> (ø)
.../admin/v2/stub/BigtableTableAdminStubSettings.java 94.26% <0.00%> (ø) 36.00 <0.00> (ø)
...able/admin/v2/BaseBigtableInstanceAdminClient.java 57.07% <78.57%> (-3.14%) 56.00 <3.00> (ø)
...igtable/admin/v2/BaseBigtableTableAdminClient.java 58.18% <80.00%> (-1.98%) 67.00 <3.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 322fc6a...3f12884. Read the comment docs.

@kolea2
Copy link
Contributor

kolea2 commented May 8, 2020

@igorbernstein2 the retry settings have been fixed, this should be good to go. PTAL

Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kolea2 kolea2 merged commit 592ff87 into master May 8, 2020
@kolea2 kolea2 deleted the autosynth branch May 8, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. context: full

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants