KEMBAR78
samples: remove _veneer from Bigtable region tags by billyjacobson · Pull Request #679 · googleapis/java-bigtable · GitHub
Skip to content

samples: remove _veneer from Bigtable region tags #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2021
Merged

samples: remove _veneer from Bigtable region tags #679

merged 1 commit into from
Mar 17, 2021

Conversation

@billyjacobson
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@billyjacobson billyjacobson requested a review from a team March 17, 2021 00:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Mar 17, 2021
@snippet-bot
Copy link

snippet-bot bot commented Mar 17, 2021 •
edited
Loading

Here is the summary of possible violations 😱

There are 8 possible violations for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 9 region tags.
You are about to delete 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codecov
Copy link

codecov bot commented Mar 17, 2021 •
edited
Loading

Codecov Report

Merging #679 (f612920) into master (922092b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #679      +/-   ##
============================================
+ Coverage     83.44%   83.45%   +0.01%     
  Complexity     1198     1198              
============================================
  Files           110      110              
  Lines          7309     7309              
  Branches        383      383              
============================================
+ Hits           6099     6100       +1     
+ Misses         1009     1007       -2     
- Partials        201      202       +1
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/bigtable/emulator/v2/Emulator.java 60.65% <0.00%> (+0.81%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922092b...f612920. Read the comment docs.

@billyjacobson billyjacobson force-pushed the remove-veneer-region-tags branch from c5a4998 to f612920 Compare March 17, 2021 18:54
@kolea2 kolea2 changed the title remove _veneer from Bigtable region tags samples: remove _veneer from Bigtable region tags Mar 17, 2021
@billyjacobson billyjacobson merged commit 810646e into master Mar 17, 2021
@billyjacobson billyjacobson deleted the remove-veneer-region-tags branch March 17, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@billyjacobson @kolea2