KEMBAR78
chore: fix integration test zones to work across all environments by igorbernstein2 · Pull Request #82 · googleapis/java-bigtable · GitHub
Skip to content

Conversation

@igorbernstein2
Copy link
Contributor

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2019
@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #82 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
- Coverage     81.29%   81.27%   -0.02%     
  Complexity      937      937              
============================================
  Files            95       95              
  Lines          5842     5842              
  Branches        325      325              
============================================
- Hits           4749     4748       -1     
- Misses          917      918       +1     
  Partials        176      176
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/bigtable/emulator/v2/Emulator.java 59.13% <0%> (-0.87%) 14% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f184012...cc8f6c3. Read the comment docs.

Copy link
Contributor

@rahulKQL rahulKQL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulKQL
Copy link
Contributor

Considering this file is being ignored by CodeCov, So merging this change now.

@rahulKQL rahulKQL merged commit 0cff0bb into googleapis:master Nov 12, 2019
@igorbernstein2 igorbernstein2 deleted the it-zone-swap branch November 12, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants