KEMBAR78
chore: fix tests by igorbernstein2 · Pull Request #83 · googleapis/java-bigtable · GitHub
Skip to content

Conversation

@igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Nov 12, 2019

  • Fix bug in the instance admin IT. This was unnoticed because our presubmits target a development instance (I just changed that)
  • Move auto-value back as a provided dep in the main dependency list. This caused issues in intellij when annotation processing was disabled
  • Disable concurrent unit tests, it makes the autogen tests flaky

* Fix bug in the instance admin IT. This was unnoticed because our presubmits target a development instance (I just changed that)
* Move auto-value back as a provided dep in the main dependency list. This caused issues in intellij when annotation processing was disabled
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2019
@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a21bf1c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #83   +/-   ##
=========================================
  Coverage          ?   81.02%           
  Complexity        ?      937           
=========================================
  Files             ?       95           
  Lines             ?     5849           
  Branches          ?      311           
=========================================
  Hits              ?     4739           
  Misses            ?      919           
  Partials          ?      191

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21bf1c...abfe700. Read the comment docs.

@igorbernstein2 igorbernstein2 merged commit f5f70e0 into googleapis:master Nov 12, 2019
@igorbernstein2 igorbernstein2 deleted the fix-broken-admin-it branch November 12, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants