KEMBAR78
fix: exclude protobuf from conformance-tests by mutianf · Pull Request #845 · googleapis/java-bigtable · GitHub
Skip to content

fix: exclude protobuf from conformance-tests #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2021
Merged

fix: exclude protobuf from conformance-tests #845

merged 2 commits into from
May 27, 2021

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented May 27, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@mutianf mutianf requested review from a team as code owners May 27, 2021 18:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label May 27, 2021
@mutianf mutianf requested a review from igorbernstein2 May 27, 2021 19:42
igorbernstein2
igorbernstein2 approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mutianf mutianf merged commit 1d89191 into googleapis:master May 27, 2021
@mutianf mutianf deleted the version branch May 27, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mutianf @igorbernstein2