chore: fix javadoc site after repo split #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
igorbernstein2
changed the title
* To ensure that the excludes are respected by both the aggregate site and the javadoc jars * move the javadoc config from reporting to build configs: this is necessary because the javadoc:jar is run as part of the build phase * move the javadoc config to the parent pom so that it can be used by both the aggregate site goal and the javadoc jars * Exclude the grpc & protobuf stubs from the aggregate site: they are not part of the public api in the java client * Remove unused external links * Stop generating unused site reports, we only use the javadocs
igorbernstein2
force-pushed
the
fix-javadoc
branch
from
75ee5a9 to
417543c
Compare
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
============================================
- Coverage 81.31% 81.07% -0.24%
Complexity 937 937
============================================
Files 95 95
Lines 5849 5849
Branches 325 311 -14
============================================
- Hits 4756 4742 -14
+ Misses 917 916 -1
- Partials 176 191 +15
Continue to review full report at Codecov.
|
chingor13
approved these changes
Nov 15, 2019
kolea2
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)