-
Notifications
You must be signed in to change notification settings - Fork 101
chore: update Error message for bad bigtable.env variable #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Yikes! Sorry about that and thank you for the fix! However I was wondering if you are modifying that property directly? It's meant to be controlled via a maven profile: ie: |
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
============================================
+ Coverage 81.07% 81.33% +0.25%
Complexity 937 937
============================================
Files 95 95
Lines 5849 5849
Branches 311 325 +14
============================================
+ Hits 4742 4757 +15
Misses 916 916
+ Partials 191 176 -15
Continue to review full report at Codecov.
|
At some point, the allowed settings were changed from "prod" and "emulator" to "cloud" and "emulator". This change updates the error message associated to the illegal argument exception.
0a944a7 to
55be605
Compare
|
Hope you don't mind, I amended your commit to comply with conventional commit messages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Thanks for the work in checking this in! |
|
May I suggest to use a combination? mvn verify -Pbigtable-prod-it -Dbigtable.project=... -Dbigtable.instance=... -Dbigtable.table=....
The bigtable.env property wasn’t meant to be set directly. Without setting the profile, you will default to the emulator profile which might configure different test cases then the prod profile |
|
Perfect, thank you for the advice. I will modify the invocation accordingly. |
At some point, the allowed settings were changed from "prod" and "emulator" to "cloud" and "emulator".
This change updates the error message associated to the illegal argument exception.