Added FILTERS.timestamp().exact() for better access & read ability.
#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
rahulKQL
force-pushed
the
timestampLookup
branch
from
2512606 to
8732523
Compare
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
============================================
+ Coverage 81.33% 81.33% +<.01%
Complexity 937 937
============================================
Files 95 95
Lines 5849 5850 +1
Branches 325 325
============================================
+ Hits 4757 4758 +1
Misses 916 916
Partials 176 176
Continue to review full report at Codecov.
|
…lity This change introduces `FILTERS.timestamp().exact()`, which enable user to directly provide exact timestamp to query Bigtable.
rahulKQL
force-pushed
the
timestampLookup
branch
from
8732523 to
ae96870
Compare
kolea2
reviewed
Nov 18, 2019
| .setTimestampRangeFilter( | ||
| TimestampRange.newBuilder() | ||
| .setStartTimestampMicros(20_000L) | ||
| .setEndTimestampMicros(20_000L + 1)) |
There was a problem hiding this comment.
TimestampRange#endTimestampMicros denotes upper bound for timestamp range. If we pass the same value then no rows will return.
There was a problem hiding this comment.
The end range cap is exclusive, so for a single number, the range is [x, x+1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65