chore: make sure that integration tests only run as part of a profile #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like maven will run integration tests w/o a profile under some circumstances. So -Pbigtable-prod-it will still run the emulator integration tests. This PR will explicitly disable default integration tests and enable them in each profile. Please note that the emulator profile is still active by default, so integration tests will still run
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=========================================
Coverage ? 81.33%
Complexity ? 937
=========================================
Files ? 95
Lines ? 5850
Branches ? 325
=========================================
Hits ? 4758
Misses ? 916
Partials ? 176Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like maven will run integration tests w/o a profile under some circumstances. So -Pbigtable-prod-it will still run the emulator integration tests. This PR will explicitly disable default integration tests and enable them in each profile.
Please note that the emulator profile is still active by default, so integration tests will still run
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)