KEMBAR78
fix: Add tests for multiple inequality support by milaGGL · Pull Request #1392 · googleapis/java-firestore · GitHub
Skip to content

fix: Add tests for multiple inequality support #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Sep 13, 2023
Merged

fix: Add tests for multiple inequality support #1392

merged 20 commits into from
Sep 13, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Aug 9, 2023 •
edited
Loading

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/java-firestore API. labels Aug 9, 2023
@milaGGL milaGGL changed the title port multiple inequality feat: Add tests for multiple inequality support Aug 9, 2023
@milaGGL milaGGL marked this pull request as ready for review August 9, 2023 19:01
@milaGGL milaGGL requested a review from a team as a code owner August 9, 2023 19:01
@milaGGL milaGGL added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner August 10, 2023 14:06
ehsannas
ehsannas reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits pointed out below.

@milaGGL milaGGL requested a review from ehsannas August 16, 2023 18:57
ehsannas
ehsannas reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Just a few minor nits below.

@milaGGL milaGGL requested a review from ehsannas August 28, 2023 19:44
ehsannas
ehsannas requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please port this unit test to this PR.

@milaGGL milaGGL requested a review from ehsannas September 1, 2023 22:38
ehsannas
ehsannas reviewed Sep 12, 2023
View reviewed changes
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java Outdated
public void multipleInequalityQueryOnDifferentPropertiesShouldBeSupported() throws Exception {
// TODO(MIEQ): Enable this test against production when possible.
assumeTrue(
"Skip this test if running against production because multiple equality is "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: multiple inequality

@milaGGL milaGGL removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 13, 2023
@milaGGL milaGGL added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2023
@milaGGL milaGGL added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 13, 2023
@milaGGL milaGGL changed the title feat: Add tests for multiple inequality support Add tests for multiple inequality support Sep 13, 2023
@milaGGL milaGGL changed the title Add tests for multiple inequality support fix: Add tests for multiple inequality support Sep 13, 2023
@milaGGL milaGGL merged commit e01b3a1 into main Sep 13, 2023
@milaGGL milaGGL deleted the mila/multiple-inequality branch September 13, 2023 17:14
@release-please release-please bot mentioned this pull request Sep 13, 2023
Merged
@milaGGL milaGGL restored the mila/multiple-inequality branch October 5, 2023 14:56
@milaGGL milaGGL deleted the mila/multiple-inequality branch October 5, 2023 15:19
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
@milaGGL @cherylEnkidu
fix: Add tests for multiple inequality support (#1392)
d61ef2d
@release-please release-please bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@milaGGL milaGGL

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milaGGL @ehsannas @yoshi-kokoro