KEMBAR78
fix: Better error message when Transaction/WriteBatch is modified after commit. by ehsannas · Pull Request #1503 · googleapis/java-firestore · GitHub
Skip to content

fix: Better error message when Transaction/WriteBatch is modified after commit. #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2023
Merged

fix: Better error message when Transaction/WriteBatch is modified after commit. #1503

merged 3 commits into from
Dec 15, 2023

Conversation

@ehsannas
Copy link
Contributor

Fixes #1183

@ehsannas ehsannas requested a review from a team as a code owner December 12, 2023 16:16
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/java-firestore API. labels Dec 12, 2023
@ehsannas ehsannas requested a review from milaGGL December 12, 2023 16:52
milaGGL
milaGGL approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milaGGL milaGGL assigned ehsannas and unassigned milaGGL Dec 13, 2023
@ehsannas ehsannas requested a review from a team as a code owner December 15, 2023 15:08
@ehsannas ehsannas merged commit 9693c7b into main Dec 15, 2023
@ehsannas ehsannas deleted the ehsann/better-error-message branch December 15, 2023 16:06
@release-please release-please bot mentioned this pull request Dec 15, 2023
Merged
@release-please release-please bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@ehsannas ehsannas

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong Exception Message in Transactions

2 participants

@ehsannas @milaGGL