KEMBAR78
feat: `Instant` support by eranl · Pull Request #1586 · googleapis/java-firestore · GitHub
Skip to content

feat: Instant support #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2024
Merged

feat: Instant support #1586

merged 2 commits into from
Feb 27, 2024

Conversation

@eranl
Copy link
Contributor

@eranl eranl commented Feb 25, 2024

Add support for java.time.Instant as a time type.

Fixes #509☕️

@eranl
feat: Instant support
289dbfa 
feat: Instant support
@eranl eranl requested a review from a team as a code owner February 25, 2024 02:26
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. labels Feb 25, 2024
@tom-andersen tom-andersen added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 26, 2024
@eranl eranl requested a review from a team as a code owner February 26, 2024 19:16
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 26, 2024
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
tom-andersen
tom-andersen approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-andersen tom-andersen merged commit 77a9bfc into googleapis:main Feb 27, 2024
@release-please release-please bot mentioned this pull request Feb 27, 2024
Merged
@release-please release-please bot mentioned this pull request May 17, 2024
Merged
@eranl eranl deleted the instant branch September 5, 2024 01:42
This was referenced Sep 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

@tom-andersen tom-andersen

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replacing Timestamp with Java8 Instant or ability to use custom serializer

3 participants

@eranl @tom-andersen @yoshi-kokoro