KEMBAR78
fix: Add configurable to run tests against different firestore backends by wu-hui · Pull Request #1659 · googleapis/java-firestore · GitHub
Skip to content

Conversation

@wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Apr 26, 2024

No description provided.

@wu-hui wu-hui requested a review from a team as a code owner April 26, 2024 15:23
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. labels Apr 26, 2024
@wu-hui wu-hui changed the title Add configurable to run tests against different firestore backends fix: Add configurable to run tests against different firestore backends Apr 26, 2024
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Apr 26, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One question/comment for consistency.

@tom-andersen tom-andersen added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2024
@tom-andersen tom-andersen assigned wu-hui and unassigned tom-andersen Apr 26, 2024
@wu-hui wu-hui force-pushed the wuandy/NightlyTests branch from 2e357ab to 5094e8b Compare April 26, 2024 16:08
@wu-hui wu-hui merged commit a60d2a3 into main Apr 26, 2024
@wu-hui wu-hui deleted the wuandy/NightlyTests branch April 26, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants