KEMBAR78
feat: Add additional Firestore query snippets by kevkim-codes · Pull Request #1790 · googleapis/java-firestore · GitHub
Skip to content

feat: Add additional Firestore query snippets #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 29, 2024
Merged

feat: Add additional Firestore query snippets #1790

merged 10 commits into from
Aug 29, 2024

Conversation

kevkim-codes
Copy link
Contributor

Creates a region tag to use for documentation: Docsite page: https://firebase.google.com/docs/firestore/query-data/multiple-range-fields

@snippet-bot
Copy link

snippet-bot bot commented Aug 13, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. samples Issues that are directly related to samples. labels Aug 13, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 14, 2024
@kevkim-codes kevkim-codes changed the title Firestore samples feat: Add additional Firestore query snippets Aug 15, 2024
@cindy-peng
Copy link

It looks like Kokoro sample tests failed with:

[ERROR] com.example.firestore.snippets.MultipleRangeInequalityFiltersSnippetsIT.testRangeMultipleInequalityFilter  Time elapsed: 0.107 s  <<< ERROR!
java.util.concurrent.ExecutionException: 
com.google.api.gax.rpc.FailedPreconditionException: io.grpc.StatusRuntimeException: FAILED_PRECONDITION: The query requires an index.

Not super familiar with firestore, do we need to create an index? https://cloud.google.com/firestore/docs/query-data/indexing

@kevkim-codes
Copy link
Contributor Author

It looks like Kokoro sample tests failed with:

[ERROR] com.example.firestore.snippets.MultipleRangeInequalityFiltersSnippetsIT.testRangeMultipleInequalityFilter  Time elapsed: 0.107 s  <<< ERROR!
java.util.concurrent.ExecutionException: 
com.google.api.gax.rpc.FailedPreconditionException: io.grpc.StatusRuntimeException: FAILED_PRECONDITION: The query requires an index.

Not super familiar with firestore, do we need to create an index? https://cloud.google.com/firestore/docs/query-data/indexing

Created new indexes for the sample build! Kokoro build passes now.

jiayou97
jiayou97 approved these changes Aug 21, 2024
View reviewed changes
Copy link

@jiayou97 jiayou97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is Jia from Firestore. Thanks for making the change!

@iennae iennae merged commit 4099e5b into googleapis:main Aug 29, 2024
@KasiaStrz
Copy link

Hi @kevkim-codes , still missing the Datastore version with region tag: datastore_query_filter_compound_multi_ineq

@release-please release-please bot mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iennae iennae iennae approved these changes

+2 more reviewers

@cindy-peng cindy-peng cindy-peng approved these changes

@jiayou97 jiayou97 jiayou97 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cindy-peng cindy-peng

Labels

api: firestore Issues related to the googleapis/java-firestore API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kevkim-codes @cindy-peng @KasiaStrz @iennae @jiayou97 @kweinmeister