fix: Remove race condition in test. #1826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
tom-andersen
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
MarkDuckworth
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI sometimes fails on
listenToDocumentsWithVectors, and as best as I can tell, it is because of race condition in test.There is a blocking call on listener that precedes incrementing semaphore that controls switch statement. Consequently, the case that deletes the document runs twice. The second time, the document has been deleted, so assertion fails on
assertNotNull(docSnap)line 1456. This can happen if the executor on listener is a thread pool capable of concurrent execution, allowing next snapshot to process, before previous snapshot is done processing.This PR makes the code more readable, and removes any chance of race condition.
I have applied this to both places where this pattern appears.