Fix: sort document reference by long type id #1945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
milaGGL
changed the title
TomasMorton
reviewed
Dec 6, 2024
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryWatchTest.java
Show resolved
Hide resolved
ehsannas
reviewed
Dec 6, 2024
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BasePath.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BasePath.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BasePath.java
Outdated
Show resolved
Hide resolved
ehsannas
approved these changes
Dec 6, 2024
|
We should add a testcase for negative numeric ID if that's allowed. |
milaGGL
commented
Dec 6, 2024
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryWatchTest.java
Show resolved
Hide resolved
TomasMorton
approved these changes
Dec 9, 2024
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BasePath.java
Outdated
Show resolved
Hide resolved
milaGGL
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document ID supports strings and well as long integers in the format of
"__id<Long>__". When sorting documents by document ID, it should be sorted in the following order: