KEMBAR78
ci: simplify java 8 unit tests by suztomo · Pull Request #1804 · googleapis/java-firestore · GitHub
Skip to content

ci: simplify java 8 unit tests #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2024
Merged

ci: simplify java 8 unit tests #1804

merged 2 commits into from
Sep 9, 2024

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Aug 30, 2024 •
edited
Loading

The Java 8 unit test special setup ("compile in Java 17 and run tests in Java 8") was introduced by the template change for java-spanner googleapis/java-spanner#1870. This java-firestore repository does not need the special setup.

@milaGGL

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/java-firestore API. labels Aug 30, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 30, 2024
@suztomo suztomo changed the title test: checking java 8 special setup is still needed or not ci: simplify java 8 unit tests Aug 30, 2024
@suztomo suztomo requested a review from milaGGL August 30, 2024 17:39
@suztomo suztomo marked this pull request as ready for review August 30, 2024 17:39
@suztomo suztomo requested review from a team as code owners August 30, 2024 17:39
milaGGL
milaGGL approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the problem in #1706.

@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2024
@suztomo
Copy link
Member Author

suztomo commented Aug 30, 2024

https://source.cloud.google.com/results/invocations/63987eea-998b-4946-98cf-b894d6fe5067

  JUnit Vintage:ITE2ETracingTestGlobalOtel:docRefUpdate6TraceTest
    MethodSource [className = 'com.google.cloud.firestore.it.ITE2ETracingTestGlobalOtel', methodName = 'docRefUpdate6TraceTest', methodParameterTypes = '']
    => com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Read requests (free)' and limit 'Read requests (free) per minute' of service 'cloudtrace.googleapis.com' for consumer 'project_number:1078988926532'.
       com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:100)
       com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:98)
       com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:66)
       com.google.api.gax.grpc.GrpcExceptionCallable$ExceptionTransformingFuture.onFailure(GrpcExceptionCallable.java:97)
       com.google.api.core.ApiFutures$1.onFailure(ApiFutures.java:84)
       [...]
       Suppressed: com.google.api.gax.rpc.AsyncTaskException: Asynchronous task failed
         com.google.api.gax.rpc.ApiExceptions.callAndTranslateApiException(ApiExceptions.java:57)
         com.google.api.gax.rpc.UnaryCallable.call(UnaryCallable.java:112)
         com.google.cloud.trace.v1.TraceServiceClient.getTrace(TraceServiceClient.java:429)
         com.google.cloud.trace.v1.TraceServiceClient.getTrace(TraceServiceClient.java:400)
         com.google.cloud.firestore.it.ITE2ETracingTest.fetchAndValidateTrace(ITE2ETracingTest.java:446)
         [...]
     Caused by: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Read requests (free)' and limit 'Read requests (free) per minute' of service 'cloudtrace.googleapis.com' for consumer 'project_number:1078988926532'.
       io.grpc.Status.asRuntimeException(Status.java:533)

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 31, 2024
@milaGGL
Copy link
Contributor

milaGGL commented Sep 5, 2024

https://source.cloud.google.com/results/invocations/63987eea-998b-4946-98cf-b894d6fe5067

  JUnit Vintage:ITE2ETracingTestGlobalOtel:docRefUpdate6TraceTest
    MethodSource [className = 'com.google.cloud.firestore.it.ITE2ETracingTestGlobalOtel', methodName = 'docRefUpdate6TraceTest', methodParameterTypes = '']
    => com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Read requests (free)' and limit 'Read requests (free) per minute' of service 'cloudtrace.googleapis.com' for consumer

These client side tracing integration tests are flaky due to quota limit. Kokoro tests should all pass after several tries.

@milaGGL milaGGL added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 5, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 5, 2024
@milaGGL milaGGL added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2024
@suztomo suztomo merged commit 29bef50 into main Sep 9, 2024
@suztomo suztomo deleted the suztomo-patch-1 branch September 9, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

No one assigned

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suztomo @milaGGL @yoshi-kokoro