KEMBAR78
fix: revert "Feat: Record serialization/deserialization" by milaGGL · Pull Request #1833 · googleapis/java-firestore · GitHub
Skip to content

Conversation

@milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Sep 18, 2024

This PR is resulting to java cloud bom failure. Reverting the change back till we fixed the java version conflict.

BEGIN_COMMIT_OVERRIDE
fix: revert "Feat: Record serialization/deserialization"
END_COMMIT_OVERRIDE

@milaGGL milaGGL requested review from a team as code owners September 18, 2024 18:14
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/java-firestore API. labels Sep 18, 2024
@suztomo suztomo changed the title Revert "Feat: Record serialization/deserialization" fix: revert "Feat: Record serialization/deserialization" Sep 18, 2024
@suztomo
Copy link
Member

suztomo commented Sep 18, 2024

When merging this pull request ensure you have "fix:" in the prefix in the commit message. This will ensure the fix will appear in the release note.

@milaGGL
Copy link
Contributor Author

milaGGL commented Sep 18, 2024

When merging this pull request ensure you have "fix:" in the prefix in the commit message. This will ensure the fix will appear in the release note.

The feature is supposed to be released in this cycle. can we remove it completely from release note, instead of having 2 note: added this feature, fix it by removing it?

@ldetmer
Copy link

ldetmer commented Sep 18, 2024

When merging this pull request ensure you have "fix:" in the prefix in the commit message. This will ensure the fix will appear in the release note.

The feature is supposed to be released in this cycle. can we remove it completely from release note, instead of having 2 note: added this feature, fix it by removing it?

I can manually update release notes to remove this

@milaGGL milaGGL added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2024
@suztomo
Copy link
Member

suztomo commented Sep 18, 2024

I can manually update release notes to remove this

Yes, that works.

@suztomo
Copy link
Member

suztomo commented Sep 18, 2024

clirr check failed https://github.com/googleapis/java-firestore/actions/runs/10927804193/job/30335326929?pr=1833

8001: com.google.cloud.firestore.encoding.CustomClassMapper: Class com.google.cloud.firestore.encoding.CustomClassMapper removed

I marked the check as non-required temporarily.

@milaGGL milaGGL merged commit 61073e3 into main Sep 18, 2024
22 of 24 checks passed
@milaGGL milaGGL deleted the revert-1706-mila/test-record branch September 18, 2024 19:01
@suztomo suztomo added the release-please:force-run To run release-please label Sep 18, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants