KEMBAR78
fix: Implement BulkWriter shutdown logic by tom-andersen · Pull Request #2202 · googleapis/java-firestore · GitHub
Skip to content

fix: Implement BulkWriter shutdown logic #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 24, 2025
Merged

fix: Implement BulkWriter shutdown logic #2202

merged 4 commits into from
Jul 24, 2025

Conversation

@tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Jul 23, 2025 •
edited
Loading

@tom-andersen tom-andersen requested a review from a team as a code owner July 23, 2025 23:21
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/java-firestore API. labels Jul 23, 2025
@tom-andersen tom-andersen changed the title Implement BulkWriter shutdown logic fix: Implement BulkWriter shutdown logic Jul 23, 2025
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2025
MarkDuckworth
MarkDuckworth previously approved these changes Jul 24, 2025
View reviewed changes
dconeybe
dconeybe previously approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix! That's definitely a "resource leak".

@tom-andersen tom-andersen dismissed stale reviews from dconeybe and MarkDuckworth via 4a84c5b July 24, 2025 15:12
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025
@tom-andersen tom-andersen merged commit 7301774 into main Jul 24, 2025
36 of 37 checks passed
@tom-andersen tom-andersen deleted the tomandersen/shutdownBulkwriterExecutor branch July 24, 2025 21:24
@release-please release-please bot mentioned this pull request Jul 15, 2025
Merged
@colin-chan colin-chan mentioned this pull request Aug 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dconeybe dconeybe dconeybe approved these changes

@MarkDuckworth MarkDuckworth Awaiting requested review from MarkDuckworth

Assignees

@MarkDuckworth MarkDuckworth

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BulkWriter release unmanageable threads

5 participants

@tom-andersen @MarkDuckworth @dconeybe @yoshi-kokoro @cloud-java-bot