-
Notifications
You must be signed in to change notification settings - Fork 75
build: update annotationProcessorPaths to include auto-service-annotations #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tions With the recent bump to auto-value-annotations 1.7 IntelliJ is not longer able to build the project due to a NoClassDefFoundError. Here we manually pull in auto-service-annotations so that it is part of the processor path because auto-value has it set to provided scope. This dependency is needed due to the retention change in google/auto@628df54 where the RetentionPolicy changed from SOURCE to CLASS. Due to the RetentionPolicy change to CLASS we must have the annotations available on the processor path otherwise the following will error will be thrown. (This is a particular problem with the annotation processor configuration in IntelliJ) Error:java: java.lang.NoClassDefFoundError: com/google/auto/service/AutoService com.google.auto.service.AutoService
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=========================================
Coverage 71.33% 71.33%
Complexity 988 988
=========================================
Files 62 62
Lines 5323 5323
Branches 599 599
=========================================
Hits 3797 3797
Misses 1339 1339
Partials 187 187Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option 2: don't use autovalue.
| <version>${auto-value.version}</version> | ||
| </path> | ||
| <!-- | ||
| There is currently no available version of auto-service-annotations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Java 7 CI failed. Perhaps we should ask @netdpb to push one compiled for Java 7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The java 7 build failed because of a timeout from maven central.
I don't know if we specifically need a release for Java 7 as we perform release builds with Java 8 and a 1.7 target.
|
IntelliJ gives no further information about that error, like a stacktrace? |
|
Correct @netdpb This is all that was printed by IntelliJ, even with |
With the recent bump to auto-value-annotations 1.7 IntelliJ is not longer
able to build the project due to a NoClassDefFoundError.
Here we manually pull in auto-service-annotations so that it is part of the
processor path because auto-value has it set to provided scope.
This dependency is needed due to the retention change in
google/auto@628df54
where the RetentionPolicy changed from SOURCE to CLASS.
Due to the RetentionPolicy change to CLASS we must have the
annotations available on the processor path otherwise the following
will error will be thrown. (This is a particular problem with the
annotation processor configuration in IntelliJ)
Error:java: java.lang.NoClassDefFoundError: com/google/auto/service/AutoService
com.google.auto.service.AutoService