KEMBAR78
test: Update assertion in failing test: ITSystemTest.readOnlyTransaction_failureWhenAttemptReadOlderThan60Seconds by dconeybe · Pull Request #589 · googleapis/java-firestore · GitHub
Skip to content

Conversation

@dconeybe
Copy link
Contributor

It appears that the message from the server has changed, causing one of the assertion checks to fail.

This commit updates the assertion to fix the test failure.

Fixes #588

…ReadOlderThan60Seconds

It appears that the message from the server has changed, causing one of the assertion checks to fail.

This commit updates the assertion to fix the test failure.

Fixes #588
@dconeybe dconeybe requested a review from a team as a code owner April 13, 2021 16:19
@dconeybe dconeybe requested a review from a team April 13, 2021 16:19
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Apr 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2021
@dconeybe dconeybe self-assigned this Apr 13, 2021
@dconeybe dconeybe changed the title Fix failing test: ITSystemTest.readOnlyTransaction_failureWhenAttemptReadOlderThan60Seconds fix: Update assertion in failing test: ITSystemTest.readOnlyTransaction_failureWhenAttemptReadOlderThan60Seconds Apr 13, 2021
@dconeybe dconeybe changed the title fix: Update assertion in failing test: ITSystemTest.readOnlyTransaction_failureWhenAttemptReadOlderThan60Seconds test: Update assertion in failing test: ITSystemTest.readOnlyTransaction_failureWhenAttemptReadOlderThan60Seconds Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #589 (cc439b5) into master (029f01d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #589   +/-   ##
=========================================
  Coverage     73.85%   73.85%           
- Complexity     1088     1097    +9     
=========================================
  Files            67       67           
  Lines          5840     5840           
  Branches        717      715    -2     
=========================================
  Hits           4313     4313           
  Misses         1302     1302           
  Partials        225      225           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029f01d...cc439b5. Read the comment docs.

@dconeybe dconeybe merged commit 66e0e88 into master Apr 13, 2021
@dconeybe dconeybe deleted the dconeybe/FixFlakyITSystemTestIssue588 branch April 13, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/java-firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

firestore.it.ITSystemTest: readOnlyTransaction_failureWhenAttemptReadOlderThan60Seconds failed

3 participants