fix: make use of ImmutableMap.Builder#buildOrThrow graceful (#2159)

BenWhitehead · web-flow · commit e9746f856e92 · 2023-08-10T13:30:06.000-04:00
`buildOrThrow` was added in guava 31.0, and while we specify a min
version &gt;= 31.0, sometimes our library is used in environments that set
different guava version (usually due to platform pinned versions).

We do not strictly need this method, as it has the same behavior of
`ImmutableMap.Builder#build()` but with a more clear name
(`ImmutableMap.Builder` never allowed duplicate keys).

Manually tested, but creating a separate project that did the following
in its maven config:
```
  &lt;dependencyManagement&gt;
    &lt;dependencies&gt;
      &lt;dependency&gt;
        &lt;groupId&gt;com.google.guava&lt;/groupId&gt;
        &lt;artifactId&gt;guava&lt;/artifactId&gt;
        &lt;version&gt;24.0-jre&lt;/version&gt;
      &lt;/dependency&gt;
      &lt;dependency&gt;
        &lt;groupId&gt;com.google.cloud&lt;/groupId&gt;
        &lt;artifactId&gt;google-cloud-storage-bom&lt;/artifactId&gt;
        &lt;version&gt;2.26.1-SNAPSHOT&lt;/version&gt;
        &lt;type&gt;pom&lt;/type&gt;
        &lt;scope&gt;import&lt;/scope&gt;
      &lt;/dependency&gt;
    &lt;/dependencies&gt;
  &lt;/dependencyManagement&gt;
  &lt;dependencies&gt;
    &lt;dependency&gt;
      &lt;groupId&gt;com.google.guava&lt;/groupId&gt;
      &lt;artifactId&gt;guava&lt;/artifactId&gt;
    &lt;/dependency&gt;
    &lt;dependency&gt;
      &lt;groupId&gt;com.google.cloud&lt;/groupId&gt;
      &lt;artifactId&gt;google-cloud-storage&lt;/artifactId&gt;
      &lt;exclusions&gt;
        &lt;exclusion&gt;
          &lt;groupId&gt;com.google.guava&lt;/groupId&gt;
          &lt;artifactId&gt;guava&lt;/artifactId&gt;
        &lt;/exclusion&gt;
      &lt;/exclusions&gt;
    &lt;/dependency&gt;
  &lt;/dependencies&gt;
```

Then issuing any RPC.
diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/UnifiedOpts.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/UnifiedOpts.java
@@ -2086,6 +2086,21 @@ public String toString() {
    */
   @SuppressWarnings("unchecked")
   static final class Opts<T extends Opt> {
+    private static final Function<ImmutableMap.Builder<?, ?>, ImmutableMap<?, ?>> mapBuild;
+
+    static {
+      Function<ImmutableMap.Builder<?, ?>, ImmutableMap<?, ?>> tmp;
+      // buildOrThrow was added in guava 31.0
+      // if it fails, fallback to the older build() method instead.
+      // The behavior was the same, but the new name makes the behavior clear
+      try {
+        ImmutableMap.builder().buildOrThrow();
+        tmp = ImmutableMap.Builder::buildOrThrow;
+      } catch (NoSuchMethodError e) {
+        tmp = ImmutableMap.Builder::build;
+      }
+      mapBuild = tmp;
+    }
 
     private final ImmutableList<T> opts;
 
@@ -2172,7 +2187,7 @@ Opts<T> projectAsSource() {
     ImmutableMap<StorageRpc.Option, ?> getRpcOptions() {
       ImmutableMap.Builder<StorageRpc.Option, Object> builder =
           rpcOptionMapper().apply(ImmutableMap.builder());
-      return builder.buildOrThrow();
+      return (ImmutableMap<StorageRpc.Option, ?>) mapBuild.apply(builder);
     }
 
     Mapper<GrpcCallContext> grpcMetadataMapper() {
