feat: allow limiting ReadChannel #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
frankyn
reviewed
Dec 16, 2021
google-cloud-storage/src/main/java/com/google/cloud/storage/BlobReadChannel.java
Outdated
Show resolved
Hide resolved
BenWhitehead
commented
Jan 18, 2022
google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBlobReadChannelTest.java
Show resolved
Hide resolved
The ReadChannel returned from storage.reader and blob.reader now allow limiting the max number of bytes the channel will make available for read. Use ReadChannel#limit(long) to set the limit. This can be used in conjunction with seek to allow for range gets of objects independent of any buffer or chunk sizes.
frankyn
reviewed
Mar 18, 2022
google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBlobReadChannelTest.java
Outdated
Show resolved
Hide resolved
frankyn
approved these changes
Mar 18, 2022
BenWhitehead
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReadChannel returned from storage.reader and blob.reader now also implemented LimitableReadChannel which allows limiting the max number of bytes the channel will make available for read.
This can be used in conjunction with seek to allow for range gets of objects independent of any buffer or chunk sizes.
See the integration tests for an example of how this could be used.